Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@ ## main #8528 +/- ## =========================================== - Coverage 86.23% 70.20% -16.03% =========================================== Files 349 348 -1 Lines 55388 55387 -1 =========================================== - Hits 47764 38887 -8877 - Misses 7624 16500 +8876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattpap reviewed Mar 20, 2026
| continue | ||
| } | ||
| if (this._is_scrolling || this._initializing || this._building || this.container === null || this.is_drawing) { | ||
| await new Promise<void>((resolve) => setTimeout(resolve, 0)) |
Collaborator
There was a problem hiding this comment.
There's defer() in @bokehjs/core/util/defer for this purpose and also delay() for non-zero timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabulator resize events are expensive (100s of milliseconds) and even though we had debouncing implemented on them it turned out that
after_layoutdidn't use the debounced version and theResizeObserverfired very eagerly while a parent was rendering. A common example might be a Column containing some widgets and a Tabulator that stretches in height, the widgets might render after the Tabulator, which then causes a resize event to occur when the widgets render and take up space. Instead of resizing then we should wait until the parent (or rather the root) says all its children are idle, i.e. resizing is the last thing that should happen.Here we await the
root.readyPromise to ensure everything has settled before the trigger the resize. Additionally we measure the width and height and avoid resizing the table unless it has measurably changed.