Handle Oauth2 ImplementationUnavailableError in microbees#166654
Open
wmoss wants to merge 1 commit intohome-assistant:devfrom
Open
Handle Oauth2 ImplementationUnavailableError in microbees#166654wmoss wants to merge 1 commit intohome-assistant:devfrom
wmoss wants to merge 1 commit intohome-assistant:devfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| Hey there @microBeesTech, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the microbees integration to handle the new OAuth2 “implementation unavailable” error so entries don’t fail permanently when cloud services can’t be fetched (e.g., no internet), and verifies this behavior with a regression test.
Changes:
- Catch
config_entry_oauth2_flow.ImplementationUnavailableErrorduring setup and raiseConfigEntryNotReadyto trigger retry. - Add integration exception translation key
oauth2_implementation_unavailablewired to the common message. - Add a test asserting the config entry moves to
SETUP_RETRYwhen the OAuth implementation cannot be loaded.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/microbees/__init__.py | Converts OAuth implementation unavailability into ConfigEntryNotReady with translated message. |
homeassistant/components/microbees/strings.json | Adds exceptions.oauth2_implementation_unavailable translation mapping to the common string. |
tests/components/microbees/test_init.py | Adds regression test ensuring setup retries on ImplementationUnavailableError. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As described in much more detail in PR #154579 and this blog post, previously, if there was no internet and the call to fetch cloud services fail, integrations like this one using cloud oauth2 would terminally fail. #154579 introduced
config_entry_oauth2_flow.ImplementationUnavailableErrorand raises it in that specific case. This catches that error and raisesConfigEntryNotReadyso that the configuration will be retried when internet is available again.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: