Skip to content

Handle Oauth2 ImplementationUnavailableError in google_tasks#166657

Open
wmoss wants to merge 1 commit intohome-assistant:devfrom
wmoss:fix-google_tasks-config-no-internet
Open

Handle Oauth2 ImplementationUnavailableError in google_tasks#166657
wmoss wants to merge 1 commit intohome-assistant:devfrom
wmoss:fix-google_tasks-config-no-internet

Conversation

@wmoss
Copy link
Contributor

@wmoss wmoss commented Mar 26, 2026

Proposed change

As described in much more detail in PR #154579 and this blog post, previously, if there was no internet and the call to fetch cloud services fail, integrations like this one using cloud oauth2 would terminally fail. #154579 introduced config_entry_oauth2_flow.ImplementationUnavailableError and raises it in that specific case. This catches that error and raises ConfigEntryNotReady so that the configuration will be retried when internet is available again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

…tion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 26, 2026 22:29
@wmoss wmoss requested a review from allenporter as a code owner March 26, 2026 22:29
@home-assistant
Copy link

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (google_tasks) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_tasks can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_tasks Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the google_tasks integration to gracefully handle the “no OAuth implementation available” startup condition introduced in #154579 by retrying setup instead of failing permanently.

Changes:

  • Catch config_entry_oauth2_flow.ImplementationUnavailableError during entry setup and raise ConfigEntryNotReady to trigger setup retries.
  • Add a localized exception message key (oauth2_implementation_unavailable) for the integration.
  • Add a regression test that verifies the config entry moves to SETUP_RETRY when the OAuth implementation is unavailable.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/google_tasks/__init__.py Converts OAuth implementation unavailability into ConfigEntryNotReady for automatic retry behavior.
homeassistant/components/google_tasks/strings.json Adds an exceptions.oauth2_implementation_unavailable message mapping to the common string.
tests/components/google_tasks/test_init.py Adds coverage for the new retry-on-unavailable-implementation behavior.
@epenet epenet changed the title Use error introduced in #154579 in google_tasks integration Handle Oauth2 ImplementationUnavailableError in google_tasks integration Mar 27, 2026
@epenet epenet changed the title Handle Oauth2 ImplementationUnavailableError in google_tasks integration Handle Oauth2 ImplementationUnavailableError in google_tasks Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment