feat: add wt.nogitignore and wt.noreadme config options#162
Open
Nymphium wants to merge 2 commits intok1LoW:mainfrom
Open
feat: add wt.nogitignore and wt.noreadme config options#162Nymphium wants to merge 2 commits intok1LoW:mainfrom
Nymphium wants to merge 2 commits intok1LoW:mainfrom
Conversation
Allow users to disable automatic creation of .gitignore and README.md in the worktree base directory via git config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CopyOptions was a subset of Config, built from Config at every call site. Pass Config directly and construct CopyOptions internally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wt.nogitignoreandwt.noreadmegit config options to skip creating.gitignoreandREADME.mdin the worktree base directoryAddWorktree/AddWorktreeWithNewBranchto acceptConfiginstead ofCopyOptions(which was a redundant subset ofConfig)Motivation
.gitignoreandREADME.mdcreation in the base directory was introduced by #81. When placing worktrees in a subdirectory (e.g.,.worktrees/) that is already ignored by a global gitignore (~/.config/git/ignore), the.gitignorecreated bygit-wt(which contains*) can cause problems with certain tools.For example, oxlint (which uses the
ignorecrate in Rust) traverses parent directories looking for .gitignorefiles and applies them — so the*` pattern ends up ignoring all files from the tool's perspective.These new config options allow users to opt out of creating these files. The default behavior does not change.
Since
AddWorktree/AddWorktreeWithNewBranchnow needConfigfor the new flags,CopyOptions(which was just a subset ofConfig, built rom it at every call site) was removed from their signatures.CopyOptionsis now constructed internally incopyAfterAdd.