chore(s3): encode url for returning public url#602
Open
purerosefallen wants to merge 1 commit intomasterfrom
Open
chore(s3): encode url for returning public url#602purerosefallen wants to merge 1 commit intomasterfrom
purerosefallen wants to merge 1 commit intomasterfrom
Conversation
shigma reviewed Apr 10, 2022
| const { buffer, filename } = await this.analyze(url, file) | ||
| const s3Key = `${this.config.pathPrefix}${filename}` | ||
| const finalUrl = `${this.config.publicUrl}${filename}` | ||
| const finalUrl = `${this.config.publicUrl}${encodeURIComponent(filename)}` |
Member
There was a problem hiding this comment.
Is slash expected as a suffix for publicUrl?
Member Author
There was a problem hiding this comment.
This is designed to match the same behavior as pathPrefix.
MaikoTan approved these changes Apr 11, 2022
shigma force-pushed the master branch 3 times, most recently from a13f0aa to 8cb4069 Compare shigma force-pushed the master branch 13 times, most recently from a6380b3 to d2d815c Compare shigma force-pushed the master branch 2 times, most recently from e08f6e0 to 78d105d Compare shigma force-pushed the master branch 5 times, most recently from 9d729d2 to 16d5f58 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 provides public assets with encoded filename. it should be encoded here.