Skip to content

Support for MP3 files < MAX_FRAME_SYNC_MATCHES#125

Open
misyltoad wants to merge 1 commit intolieff:masterfrom
misyltoad:short-mp3s
Open

Support for MP3 files < MAX_FRAME_SYNC_MATCHES#125
misyltoad wants to merge 1 commit intolieff:masterfrom
misyltoad:short-mp3s

Conversation

@misyltoad
Copy link
Copy Markdown

@misyltoad misyltoad commented Aug 9, 2024

If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file.

Fixes: #102
@misyltoad misyltoad mentioned this pull request Aug 9, 2024
Closed
misyltoad added a commit to misyltoad/VAudio-MiniMP3 that referenced this pull request Aug 9, 2024
@misyltoad
Support for short MP3 files
f03fbce 
If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file. lieff/minimp3#125
@manxorist
Copy link
Copy Markdown
Contributor

manxorist commented Aug 15, 2024

This makes the tests fail:

manx@sagnix:~/projects/minimp3/minimp3.git$ ./scripts/test.sh ~/projects/minimp3/minimp3.git ~/projects/minimp3/minimp3.git rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_center2.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_dual.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_dynx22.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_dynx31.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_dynx32.bit exited with code=0 error: reference and produced number of samples do not match (20736/0) vectors/ILL2_ext_switching.bit exited with code=1

I have not looked into why that is.
@misyltoad
Support for MP3 files < MAX_FRAME_SYNC_MATCHES
aab1ed2 
If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file. Fixes: lieff#102
manxorist added a commit to OpenMPT/openmpt that referenced this pull request Aug 15, 2024
@manxorist
[Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/r…
a628aa3 
…eleases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@21446 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist added a commit to OpenMPT/openmpt that referenced this pull request Aug 15, 2024
@manxorist
Merged revision(s) 21446 from trunk/OpenMPT:
523dc3d 
[Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.31@21447 56274372-70c3-4bfc-bfc3-4c3a0b034d27
@misyltoad
Copy link
Copy Markdown
Author

misyltoad commented Aug 15, 2024

curious as to if it is fixed on what I just pushed today? i had a typo
@manxorist
Copy link
Copy Markdown
Contributor

manxorist commented Aug 15, 2024

curious as to if it is fixed on what I just pushed today? i had a typo

Yes, the tests pass now.
dimhotepus added a commit to Source-Authors/minimp3 that referenced this pull request Mar 27, 2025
@dimhotepus
mr: Fix issue with playing small MP3 files
497f0b4 
See lieff#125
manxorist added a commit to OpenMPT/openmpt that referenced this pull request Nov 7, 2025
@manxorist
Merged revision(s) 18570, 21443, 21446, 21451 from trunk/OpenMPT:
70e1cdc 
[Ref] minimp3: Silence warning. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v2> commit 30b5aea9b6d000f197798ddd44476b641a4d0ba7 (2024-08-15). This applies the following pull requests: <lieff/minimp3#126>, <lieff/minimp3#96>, <lieff/minimp3#97>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v4> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#127>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.30@24370 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist added a commit to OpenMPT/openmpt that referenced this pull request Nov 7, 2025
@manxorist
Merged revision(s) 18570, 21443, 21446, 21451 from trunk/OpenMPT:
7364365 
[Ref] minimp3: Silence warning. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v2> commit 30b5aea9b6d000f197798ddd44476b641a4d0ba7 (2024-08-15). This applies the following pull requests: <lieff/minimp3#126>, <lieff/minimp3#96>, <lieff/minimp3#97>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v4> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#127>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.29@24373 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist added a commit to OpenMPT/openmpt that referenced this pull request Nov 7, 2025
@manxorist
Merged revision(s) 18570, 21443, 21446, 21451 from trunk/OpenMPT:
e421710 
[Ref] minimp3: Silence warning. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v2> commit 30b5aea9b6d000f197798ddd44476b641a4d0ba7 (2024-08-15). This applies the following pull requests: <lieff/minimp3#126>, <lieff/minimp3#96>, <lieff/minimp3#97>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. ........ [Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v4> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#127>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.28@24377 56274372-70c3-4bfc-bfc3-4c3a0b034d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@misyltoad @manxorist