Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

additional tests for eth_estimateGas#44

Merged
fjl merged 1 commit intolightclient:mainfrom
bomanaps:test-eip7702-7623
Oct 15, 2025
Merged

additional tests for eth_estimateGas#44
fjl merged 1 commit intolightclient:mainfrom
bomanaps:test-eip7702-7623

Conversation

@bomanaps
Copy link
Copy Markdown
Contributor

This PR introduces new tests cases for EIP-7702 and EIP-7623 within the eth_estimateGas suite. Specifically, it includes scenarios where:

  • Authorization costs increase the overall gas required to execute a transaction.
  • The floor calldata cost exceeds the execution gas cost.
  • Combined effects of floor calldata cost and authorization costs.
    As per this issue

Add eth_estimateGas tests for EIP-7702 and EIP-7623 ethereum/execution-apis#638

@bomanaps
Copy link
Copy Markdown
Contributor Author

@fjl fjl changed the title Additional test for ethstimategas additional tests for eth_estimateGas Oct 14, 2025
@fjl fjl merged commit 37cac94 into lightclient:main Oct 15, 2025
2 checks passed
@fjl
Copy link
Copy Markdown
Collaborator

fjl commented Oct 23, 2025

I've checked these tests in more detail, and had to remove some of them again. I think this PR had some misunderstandings of how RPC testing works. Specifically, I have removed

  • estimate-floor-calldata-cost-dominates
  • estimate-calldata-and-auth-floor

These test cases tried to check for an invariant by comparing the return value of eth_estimateGas with a number computed in the test generator. The problem is, this check will happen during test generation, but it makes no difference to the test execution, because we do not run rpctestgen against the client under test. When we test, we replay the generated test vectors. For eth_estimateGas, since the result is not guaranteed to be deterministic, we just check the client returns a string. Basically the removed test cases did not increase coverage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants