Feature: remove tchar.h, bring the project code base to Unicode#55
Open
Demonese wants to merge 2 commits intomicrosoft:mainfrom
Open
Feature: remove tchar.h, bring the project code base to Unicode#55Demonese wants to merge 2 commits intomicrosoft:mainfrom
Demonese wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Demonese force-pushed the feature/no-tchar branch from 24f1c7a to 71ff291 Compare 
Member
| This codebase is ancient, so that's why TCHAR still was there... I appreciate the effort to clean it up. |
Demonese force-pushed the feature/no-tchar branch from 71ff291 to 7b3abc9 Compare 
Demonese force-pushed the feature/no-tchar branch from 0b64fda to a8242b4 Compare 
Contributor Author
| I ran all the GitHub actions in my fork and they all passed. I think it's ready to be merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Unicode!
There is a problem of mixing
charandtcharin this project.So I spent some time migrating it to Unicode.