Open
Conversation
sonichi reviewed Mar 30, 2023
Contributor
sonichi left a comment
sonichi left a comment There was a problem hiding this comment.
Could you add a test to make sure this exception is raised and handled correctly?
sonichi reviewed Apr 4, 2023
Comment on lines +411 to +417
| def test_reach(self): | ||
| search_space = { | ||
| "params": tune.choice( | ||
| [{"param": "None"}, {"param": tune.qrandint(10, 100, 10)}] | ||
| ), | ||
| } | ||
| return search_space |
Contributor
There was a problem hiding this comment.
This only creates a search space. It won't trigger the exception.
Please make sure your test triggers the exception by testing it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a try except block.
Related issue number
#903
Checks