Skip to content

Make e2e tests match on exact results from TMDB #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtlynch merged 1 commit into from
Feb 16, 2026
Merged

Make e2e tests match on exact results from TMDB #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions e2e/reviews.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ test("adds a new movie rating and fills in only required fields", async ({
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("slow lear");
await page.getByText("Slow Learners (2015)").click();
await page.getByText("Slow Learners (2015)", { exact: true }).click();

await expect(page).toHaveURL(
"/reviews/new/write?tmdbId=333287&mediaType=movie"
Expand Down Expand Up @@ -186,7 +186,7 @@ test("adds a new movie rating but hides spoilers", async ({ page }) => {
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("the sixth se");
await page.getByText("The Sixth Sense (1999)").click();
await page.getByText("The Sixth Sense (1999)", { exact: true }).click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=745&mediaType=movie");
await expect(
Expand Down Expand Up @@ -234,7 +234,7 @@ test("adds a new TV show rating and fills in only required fields", async ({
await page.getByLabel("TV show").click();

await page.getByPlaceholder("Search").pressSequentially("30 r");
await page.getByText("30 Rock (2006)").click();
await page.getByText("30 Rock (2006)", { exact: true }).click();

await expect(page).toHaveURL("/reviews/new/tv/pick-season?tmdbId=4608");
await page.getByLabel("Season").selectOption({ label: "5" });
Expand Down Expand Up @@ -321,7 +321,9 @@ test("adds a new movie rating that's too long to display in a card", async ({
await page
.getByPlaceholder("Search")
.pressSequentially("Weird: The Al Yankovic Story");
await page.getByText("Weird: The Al Yankovic Story (2022)").click();
await page
.getByText("Weird: The Al Yankovic Story (2022)", { exact: true })
.click();

await expect(page).toHaveURL(
"/reviews/new/write?tmdbId=928344&mediaType=movie"
Expand Down Expand Up @@ -413,7 +415,9 @@ test("adds a new rating and fills all fields", async ({ page }) => {
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("eternal sunshine");
await page.getByText("Eternal Sunshine of the Spotless Mind (2004)").click();
await page
.getByText("Eternal Sunshine of the Spotless Mind (2004)", { exact: true })
.click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=38&mediaType=movie");
await expect(
Expand Down Expand Up @@ -465,7 +469,9 @@ test("HTML tags in reviews are stripped from review excerpt", async ({
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("eternal sunshine");
await page.getByText("Eternal Sunshine of the Spotless Mind (2004)").click();
await page
.getByText("Eternal Sunshine of the Spotless Mind (2004)", { exact: true })
.click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=38&mediaType=movie");
await expect(
Expand Down Expand Up @@ -502,7 +508,9 @@ test("adds a new movie rating and edits the details", async ({ page }) => {
await page
.getByPlaceholder("Search")
.pressSequentially("something about mary");
await page.getByText("There's Something About Mary (1998)").click();
await page
.getByText("There's Something About Mary (1998)", { exact: true })
.click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=544&mediaType=movie");
await expect(
Expand Down Expand Up @@ -580,7 +588,7 @@ test("adds a new rating and cancels the edit", async ({ page }) => {
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("the english pati");
await page.getByText("The English Patient (1996)").click();
await page.getByText("The English Patient (1996)", { exact: true }).click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=409&mediaType=movie");
await expect(
Expand Down Expand Up @@ -638,7 +646,7 @@ test("editing another user's review fails", async ({ page, browser }) => {
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("the english pati");
await page.getByText("The English Patient (1996)").click();
await page.getByText("The English Patient (1996)", { exact: true }).click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=409&mediaType=movie");
await expect(
Expand Down Expand Up @@ -907,7 +915,7 @@ test("adds a new movie rating without a numeric rating", async ({ page }) => {
await page.getByRole("button", { name: "Add Rating" }).click();

await page.getByPlaceholder("Search").pressSequentially("the godfather");
await page.getByText("The Godfather (1972)").click();
await page.getByText("The Godfather (1972)", { exact: true }).click();

await expect(page).toHaveURL("/reviews/new/write?tmdbId=238&mediaType=movie");
await expect(
Expand Down