Support for custom authorization header and skip canary check#158
Open
ppacher wants to merge 1 commit intonextcloud:masterfrom
Open
Support for custom authorization header and skip canary check#158ppacher wants to merge 1 commit intonextcloud:masterfrom
ppacher wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Patrick Pacher <patrick.pacher@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR adds two additional (optional) parameters to the BasicAuth class:
authorization)The above changes are required to integrate with services, for example Authelia, that expect a different "Authorization" header and do not reply with "WWW-Authenticate" because they don't want the browsers to show the "User/Password" dialog.
Changes should be backwards compatible.