plugins/lsp/vue_ls: add vtslsIntegration option#3815
plugins/lsp/vue_ls: add vtslsIntegration option#3815sportshead wants to merge 2 commits intonix-community:mainfrom
Conversation
| assertion = (cfg.tslsIntegration or cfg.vtslsIntegration) -> (cfg.package != null); | ||
| message = "When `${opts.tslsIntegration}` or `${opts.vtslsIntegration}` is enabled, `${opts.package}` must not be null."; | ||
| }; | ||
| plugins.lsp.servers.ts_ls = lib.mkIf (cfg.enable && cfg.tslsIntegration) { |
There was a problem hiding this comment.
| plugins.lsp.servers.ts_ls = lib.mkIf (cfg.enable && cfg.tslsIntegration) { | |
| plugins.lsp.servers.ts_ls = lib.mkIf cfg.tslsIntegration { |
Everything in extraConfig is already conditioned on cfg.enable:
nixvim/lib/plugins/mk-neovim-plugin.nix
Lines 93 to 107 in a1d3ca9
There was a problem hiding this comment.
This is unresolved. Perhaps it was reverted in a rebase?
There was a problem hiding this comment.
Yes, good catch, must have dropped it by accident
| I'm hesitant to add new features to But I also don't want to block a PR on us figuring out how to approach that. |
| This doesn't really add a new feature per se, it only adds the existing feature (automatic vue_ls compatibility) to vtsls in addition to tsls which already had it. Although I do get what you mean, this does need to be migrated to the new |
Add a vue_ls integration by default for vtsls in addition to tsls which is already implemented (see nix-community#3771). Haven't added it to Volar since it is deprecated anyway (nix-community#3600)
sportshead force-pushed the vue_ls-vtsls branch from 041bd29 to 0f947b3 Compare 
| in | ||
| { | ||
| assertions = lib.nixvim.mkAssertions "plugins.lsp.servers.vue_ls" { | ||
| assertion = (cfg.tslsIntegration or cfg.vtslsIntegration) -> (cfg.package != null); |
There was a problem hiding this comment.
| assertion = (cfg.tslsIntegration or cfg.vtslsIntegration) -> (cfg.package != null); | |
| assertion = (cfg.tslsIntegration || cfg.vtslsIntegration) -> (cfg.package != null); |
This is the wrong "or" operator; logical or (||) vs attribute selection fallback (or)
| }; | ||
| }; | ||
| }; | ||
| plugins.lsp.servers.vtsls = lib.mkIf (cfg.enable && cfg.vtslsIntegration) { |
There was a problem hiding this comment.
https://github.com/nix-community/nixvim/pull/3815/changes#r2529224980 also applies here:
| plugins.lsp.servers.vtsls = lib.mkIf (cfg.enable && cfg.vtslsIntegration) { | |
| plugins.lsp.servers.vtsls = lib.mkIf cfg.vtslsIntegration { |
| assertion = (cfg.tslsIntegration or cfg.vtslsIntegration) -> (cfg.package != null); | ||
| message = "When `${opts.tslsIntegration}` or `${opts.vtslsIntegration}` is enabled, `${opts.package}` must not be null."; | ||
| }; | ||
| plugins.lsp.servers.ts_ls = lib.mkIf (cfg.enable && cfg.tslsIntegration) { |
There was a problem hiding this comment.
This is unresolved. Perhaps it was reverted in a rebase?
3 participants
Add a vue_ls integration by default for vtsls in addition to tsls which is already implemented (see #3771).
Haven't added it to Volar since it is deprecated anyway (#3600)