feat: pipe buffer output to new document#945
Open
majiayu000 wants to merge 1 commit intonoborus:masterfrom
Open
feat: pipe buffer output to new document#945majiayu000 wants to merge 1 commit intonoborus:masterfrom
majiayu000 wants to merge 1 commit intonoborus:masterfrom
Conversation
noborus reviewed Jan 11, 2026
Owner
noborus left a comment
There was a problem hiding this comment.
Since I did not receive a reply to my comment on #944, I will comment here.
I cannot merge changes that add new features without a clear use case or intended usage.
Could you please explain in more detail how you expect each of pipe_buffer and pipe_buffer_doc to be used?
Are both actions necessary as separate features, and in what scenarios would each be used?
Understanding the intended use cases will help determine whether both are needed or if one is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Follow-up to feedback on #944 about offering pipe output as a new document and avoiding a default | binding.
Testing