Skip to content

feat: pipe buffer output to new document#945

Open
majiayu000 wants to merge 1 commit intonoborus:masterfrom
majiayu000:pipe-buffer-doc
Open

feat: pipe buffer output to new document#945
majiayu000 wants to merge 1 commit intonoborus:masterfrom
majiayu000:pipe-buffer-doc

Conversation

@majiayu000
Copy link
Copy Markdown

Summary

  • add pipe buffer actions for terminal output and for opening output as a new document
  • avoid a default key binding; document how to bind pipe_buffer/pipe_buffer_doc
  • add a DocPipe type to label pipe output documents

Motivation

Follow-up to feedback on #944 about offering pipe output as a new document and avoiding a default | binding.

Testing

  • go test ./oviewer
Copy link
Copy Markdown
Owner

@noborus noborus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I did not receive a reply to my comment on #944, I will comment here.
I cannot merge changes that add new features without a clear use case or intended usage.
Could you please explain in more detail how you expect each of pipe_buffer and pipe_buffer_doc to be used?
Are both actions necessary as separate features, and in what scenarios would each be used?
Understanding the intended use cases will help determine whether both are needed or if one is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants