Skip to content

handling filtering based on resource type only#1292

Open
jcchr wants to merge 2 commits intomainfrom
jchrapko/too_less_users
Open

handling filtering based on resource type only#1292
jcchr wants to merge 2 commits intomainfrom
jchrapko/too_less_users

Conversation

@jcchr
Copy link
Copy Markdown
Contributor

@jcchr jcchr commented Sep 10, 2025

📝 Description

Currently - filtering a list of users based on resourceType only includes also id of a workspaces that belongs to a caller of this endpoint. Within this PR I removed this additional filtering - resolving the issue found during diagnosis of the #1274.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Check if on environments with support for multi workspaces a list of users for "All workspaces" contains the same users as when you choose any certain workspace.

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and meaningful
  • ✍️ PR description clearly explains the changes and their reason
  • 📝 I have linked the PR to the corresponding GitHub Issues, if any
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works
Copilot AI review requested due to automatic review settings September 10, 2025 13:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in user filtering logic where filtering by resource type alone was incorrectly requiring a resource ID. The fix allows filtering users based solely on resource type without needing a specific workspace ID.

  • Changed the filtering condition to require both resource type AND resource ID instead of resource type OR resource ID
  • Added debug logging to help track role filtering behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants