Skip to content

[Repo Assist] refactor: remove dead ClassifyNotification method, fix reflection tests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −15
Draft

[Repo Assist] refactor: remove dead ClassifyNotification method, fix reflection tests #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/OpenClaw.Shared/OpenClawGatewayClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,11 +1562,6 @@ private void EmitNotification(string text)
NotificationReceived?.Invoke(this, notification);
}

private static (string title, string type) ClassifyNotification(string text)
{
return NotificationCategorizer.ClassifyByKeywords(text);
}

// --- Utility ---

private static ActivityKind ClassifyTool(string toolName)
Expand Down
14 changes: 4 additions & 10 deletions tests/OpenClaw.Shared.Tests/OpenClawGatewayClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,14 @@ public GatewayClientTestHelper()

public string ClassifyNotification(string text)
{
var method = typeof(OpenClawGatewayClient).GetMethod("ClassifyNotification",
System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
var result = method!.Invoke(null, new object[] { text });
var tuple = ((string title, string type))result!;
return tuple.type;
var (_, type) = NotificationCategorizer.ClassifyByKeywords(text);
return type;
}

public string GetNotificationTitle(string text)
{
var method = typeof(OpenClawGatewayClient).GetMethod("ClassifyNotification",
System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
var result = method!.Invoke(null, new object[] { text });
var tuple = ((string title, string type))result!;
return tuple.title;
var (title, _) = NotificationCategorizer.ClassifyByKeywords(text);
return title;
}

public ActivityKind ClassifyTool(string toolName)
Expand Down