Support changing properties in Maven profiles#7031
Open
Conversation
Properties defined in project/profiles/profile/properties are not currently changed by the ChangePropertyValue recipe. These tests reproduce the issue reported in moderneinc/customer-requests#1798.
ChangePropertyValue only matched properties under /project/properties. Maven also allows properties in /project/profiles/profile/properties. Add PROFILE_PROPERTY_MATCHER and isProfilePropertyTag() to MavenVisitor following the existing pattern for profile-scoped matchers, and use it in ChangePropertyValue. Fixes moderneinc/customer-requests#1798
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChangePropertyValuenow also matches properties defined in/project/profiles/profile/propertiesPROFILE_PROPERTY_MATCHERandisProfilePropertyTag()toMavenVisitorfollowing the existing pattern for profile-scoped matchersProblem
The
ChangePropertyValuerecipe only changes properties under/project/properties. Maven also allows property definitions inside profiles at/project/profiles/profile/properties. Customers using profile-scoped properties (e.g.,sonar.host.urlin a<profile>) were not getting their values updated.Solution
Added a
PROFILE_PROPERTY_MATCHERXPath matcher (/project/profiles/profile/properties/*) andisProfilePropertyTag()method toMavenVisitor, following the existing pattern used for dependencies, plugins, etc. UpdatedChangePropertyValueto check bothisPropertyTag()andisProfilePropertyTag().Test plan
Existing tests pass
New test: property only in profile gets changed
New test: property in both project and profile gets changed in both locations
New test: unrelated profile properties are not changed
Fixes moderneinc/customer-requests#1798