Remove empty methods in ssh extension#350
Merged
Conversation
tfoote approved these changes Feb 18, 2026
Collaborator
tfoote left a comment
tfoote left a comment There was a problem hiding this comment.
Thanks for the fixup. I didn't plan for full backwards compatibility on this as that function was previously never used and I assumed that there was no implementations prior.
tfoote added a commit to tfoote/ghrocker that referenced this pull request Feb 18, 2026
Removed unused precondition and validation methods. Same fix as osrf/rocker#350
This was referenced Feb 18, 2026
tfoote added a commit to tfoote/ghrocker that referenced this pull request Feb 18, 2026
Removed unused precondition and validation methods. Same fix as osrf/rocker#350
tfoote added a commit that referenced this pull request Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH extension was broken by the change to the
validate_environmentmethod introduced in #338.Since the method was empty and is already implemented in the base
RockerExtensionclass, I went ahead and removed it fromSshextension class. And did the same for the also emptyprecondition_environmentsince I was on it.