BUG: fix extra trailing bin in resample("D", closed="right")#64795
Draft
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Draft
BUG: fix extra trailing bin in resample("D", closed="right")#64795jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
…dev#62200) When Day was changed from a Tick subclass, the non-Tick path in _get_timestamp_range_edges unconditionally extended last by one freq, creating a spurious empty bin when closed="right" and last was already on a Day boundary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jbrockmendel force-pushed the bug-resample-right branch from 54a6899 to 9110067 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resample("D", closed="right")produced an extra trailing empty bin compared toresample("24h", closed="right")when the last value falls on a Day boundary (midnight).Daywas changed from aTicksubclass, the non-Tick path in_get_timestamp_range_edgesunconditionally extendedlastby one freq. Now it skips the extension whenclosed="right", freq isDay, andlastis already at midnight.closes #62200
Test plan
test_resample_D_closed_right_no_extra_bin— verifiesDand24hproduce the same result withclosed="right"test_resample_D_closed_right_label_right_no_extra_bin— original reproducer from the issuetest_resample_D_closed_right_not_on_boundary— ensures trailing bin is still present when last value is not at midnight🤖 Generated with Claude Code