BUG: fix is_subperiod/is_superperiod identity for M/Q/Y frequencies#64804
Draft
jbrockmendel wants to merge 10 commits intopandas-dev:mainfrom
Draft
BUG: fix is_subperiod/is_superperiod identity for M/Q/Y frequencies#64804jbrockmendel wants to merge 10 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 10 commits intopandas-dev:mainfrom
Conversation
The fast_float subproject (added in GH#64432) requires C++11+ features such as brace initialization. Some compilers (e.g. Apple clang 15) default to C++98, causing build failures. Explicitly set cpp_std=c++17 to match the c_std=c11 already specified for C. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
C17 is a bugfix release over C11 with no breaking changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…andas-dev#18553) is_subperiod(x, x) and is_superperiod(x, x) incorrectly returned False for monthly, quarterly, and annual frequencies while returning True for daily and sub-daily. This caused same-frequency resampling with M/Q/Y to bypass aggregation via asfreq(), returning raw values instead of aggregation results (e.g. .count() returning original values). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_subperiod(x, x)andis_superperiod(x, x)incorrectly returnedFalsefor monthly, quarterly, and annual frequencies while returningTruefor daily and sub-daily frequenciesasfreq()), returning raw values instead of aggregation results (e.g..count()returning original values instead of counts)closes #18553
Test plan
test_is_subperiod_identity— verifies identity returnsTruefor all base frequenciestest_is_subperiod_anchored_identity— verifies anchored annual/quarterly variantstest_resample_same_freq_aggregation— verifies.count(),.sum(),.mean()produce correct aggregation results for M/Q/Y🤖 Generated with Claude Code