Open
Conversation
306f624 to b717d5d Compare WhyNotHugo reviewed Oct 23, 2021
Member
WhyNotHugo left a comment
There was a problem hiding this comment.
I've mixed feelings here. I like the idea, but this breaks compat with the vdir format. Two actual issues are:
vdirsycnersyncs this to CalDav servers. I'm not entirely sure they support this format. It might be worth just trying, but if it doesn't work syncing to servers and other clients, that'd be a dealbreaker.khalwill fail to parse these and stop showing colours. I use khal myself, and othertodomanusers do too. Parallel support in khal could be required.
Author
| Thanks for the feedback. I wasn't aware the color setting was something standardized. I guess my provider doesn't support syncing colors. Khal has a config option for manually setting colors, so I guess something similar could be implemented here, would that make sense? |
Co-authored-by: Hugo Osvaldo Barrera <hugo@barrera.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I frequently change my terminal colors, and setting RGB colors for my todo folders often leads to unreadable text.
I thought it would be nice to offer an option for setting one of the usual 16 terminal colors, in addition to the 24-bit rgb ones. So, i've added support for them.
It works for all the 16 ansi colors (including the 8 bright ones).
This possibly fixes #297
Here's how it looks like (using dracula scheme, and colors

red,cyan, andbright purple(which my terminal renders as bold purple) for the folders):