Draft
Conversation
…xhigh: Please look at the repository. Carefully study all markdown files, and pay special attention to the architectural boundaries defined. This repository implements an ORM that currently only supports Postgres. I want you to identify all the areas we need to extend in order to also support SQLite. In addition to adding support, I want to also duplicate the demo app and port all the existing queries to SQLite. Please create a SQLITE-PLAN.md file that I can hand over to a coding agent to implement this. Point out all the work that has to be done, and be very explicit about the architectural boundaries we need to respect. Add a section called Architectural Challenges, and instruct the agent to list and explain any issues it has with the existing architectural decisions. It could be that we need to change some of the rules, but I want to have those changes clearly listed. After completing the plan document, start implementation.
| Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Note 🎁 Summarized by CodeRabbit FreeThe PR author is not assigned a seat. To perform a comprehensive line-by-line review, please assign a seat to the pull request author through the subscription management page by visiting https://app.coderabbit.ai/login. Comment |
wmadden reviewed Feb 6, 2026
Comment on lines +927 to +961
| if (targetId === 'sqlite') { | ||
| return [ | ||
| { | ||
| sql: `create table if not exists prisma_contract_marker ( | ||
| id integer primary key, | ||
| core_hash text not null, | ||
| profile_hash text not null, | ||
| contract_json text, | ||
| canonical_version integer, | ||
| updated_at text not null default (CURRENT_TIMESTAMP), | ||
| app_tag text, | ||
| meta text not null default '{}' | ||
| )`, | ||
| params: [], | ||
| }, | ||
| ]; | ||
| } | ||
| | ||
| // Default: Postgres schema + table. | ||
| return [ | ||
| { sql: 'create schema if not exists prisma_contract', params: [] }, | ||
| { | ||
| sql: `create table if not exists prisma_contract.marker ( | ||
| id smallint primary key default 1, | ||
| core_hash text not null, | ||
| profile_hash text not null, | ||
| contract_json jsonb, | ||
| canonical_version int, | ||
| updated_at timestamptz not null default now(), | ||
| app_tag text, | ||
| meta jsonb not null default '{}' | ||
| )`, | ||
| params: [], | ||
| }, | ||
| ]; |
Contributor
There was a problem hiding this comment.
We need an abstraction for this - it can't be a switch statement on target ID. Perhaps we could delegate this to the control adapter?
wmadden reviewed Feb 6, 2026
Comment on lines 10 to +15
| readonly postgres?: { | ||
| readonly nativeType: string; // e.g. 'integer', 'text', 'vector', 'timestamp with time zone' | ||
| }; | ||
| readonly sqlite?: { | ||
| readonly nativeType: string; // e.g. 'integer', 'text', 'real' | ||
| }; |
Contributor
There was a problem hiding this comment.
No target-keyed dictionaries in the SQL domain
wmadden reviewed Feb 6, 2026
Comment on lines +915 to +924
| type SqlStatement = { readonly sql: string; readonly params: readonly unknown[] }; | ||
| | ||
| type WriteMarkerInput = { | ||
| readonly coreHash: string; | ||
| readonly profileHash: string; | ||
| readonly contractJson?: unknown; | ||
| readonly canonicalVersion?: number | null; | ||
| readonly appTag?: string | null; | ||
| readonly meta?: Record<string, unknown>; | ||
| }; |
Contributor
There was a problem hiding this comment.
The control plane has been suffering for lack of a DDL query interface - this is really highlighted now 🙈
wmadden reviewed Feb 6, 2026
Comment on lines 41 to +56
| if (config.contract.target === 'postgres') { | ||
| return { | ||
| createAdapter: () => new PostgresAdapter(), | ||
| createDriver: () => new KyselyPrismaDriver(config), | ||
| createIntrospector: (db: Kysely<unknown>) => new PostgresIntrospector(db), | ||
| createQueryCompiler: () => new PostgresQueryCompiler(), | ||
| }; | ||
| } | ||
| if (config.contract.target === 'sqlite') { | ||
| return { | ||
| createAdapter: () => new SqliteAdapter(), | ||
| createDriver: () => new KyselyPrismaDriver(config), | ||
| createIntrospector: (db: Kysely<unknown>) => new SqliteIntrospector(db), | ||
| createQueryCompiler: () => new SqliteQueryCompiler(), | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
OMG another switch statement on target ID 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt: