http: add accept_any_response option to treat any HTTP status as success#1482
Open
serrrios wants to merge 1 commit intoprometheus:masterfrom
Open
http: add accept_any_response option to treat any HTTP status as success#1482serrrios wants to merge 1 commit intoprometheus:masterfrom
serrrios wants to merge 1 commit intoprometheus:masterfrom
Conversation
…ess; keep header/body/CEL validations intact
SuperQ reviewed Oct 30, 2025
| [ valid_status_codes: [<int>, ...] | default = 2xx ] | ||
| | ||
| # Consider any HTTP status code (1xx–5xx) as a successful probe before applying other checks. | ||
| [ accept_any_response: <boolean> | default = false ] |
Member
There was a problem hiding this comment.
This is not "any response" it's "any status code"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces new optional boolean http.accept_any_response. When enabled any HTTP status (1xx-5xx) is treated as success before header body CEL checks. Rationale: reduce false negatives when non-2xx are acceptable. Changes: add field to HTTPProbe, update prober/http.go, docs and example. Backward compatibility: opt in only. Tests: cover non-2xx with flag on and keep validations.