dns: make query_name optional; fallback to target hostname when omitted#1483
Open
serrrios wants to merge 1 commit intoprometheus:masterfrom
Open
dns: make query_name optional; fallback to target hostname when omitted#1483serrrios wants to merge 1 commit intoprometheus:masterfrom
serrrios wants to merge 1 commit intoprometheus:masterfrom
Conversation
…ed; update documentation accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes dns.query_name optional. When omitted the prober uses the hostname part of target. Rationale: simplifies common configs and reduces duplication. Changes: remove mandatory check in DNSProbe.UnmarshalYAML; derive qName in prober/dns.go; update documentation. Backward compatibility: existing configs continue to work. Tests: keep explicit query_name behavior and add fallback coverage.