fix: return on grpc.NewClient error and propagate probe context#1557
Open
Aprazor wants to merge 1 commit intoprometheus:masterfrom
Open
fix: return on grpc.NewClient error and propagate probe context#1557Aprazor wants to merge 1 commit intoprometheus:masterfrom
Aprazor wants to merge 1 commit intoprometheus:masterfrom
Conversation
Two fixes in ProbeGRPC: 1. When grpc.NewClient returns an error, execution continued into a nil conn, causing a panic. Add 'return false' after the error. 2. client.Check used context.Background() instead of the probe ctx, bypassing the scrape timeout. Use ctx to honor the deadline. Signed-off-by: Aprazors <Aprazors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in ProbeGRPC:
a nil conn, causing a panic. Add 'return false' after the error.
bypassing the scrape timeout. Use ctx to honor the deadline.
Signed-off-by: Aprazors Aprazors@gmail.com