Open
Conversation
| 🧪 Flashlight Performance Report (AWS Device Farm) 🔀 Commit: 9c4af76
|
janicduplessis changed the title janicduplessis force-pushed the @janic/sandbox-e2e-test branch from 0dae5cc to 0229901 Compare ![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Adds automated Maestro tests that verify the sandbox correctly blocks unauthorized HTTP and WebSocket connections while allowing approved domains. Moves TestDeeplinkHandler to features/e2e/ domain structure.
- Native module test: verifies NativeModules proxy blocks access from non-whitelisted files - WebView initial load test: loads blocked URL directly, asserts onError - WebView JS navigation test: loads allowed page, attempts JS navigation to blocked URL, verifies URL didn't change via postMessage - Simplified Maestro assertions to just check overall pass/fail
…dbox Checks out @janic/sandbox-e2e-test branch of rainbow-scripts (includes webview fork override + SANDBOX_BRANCH support) and sets SANDBOX_BRANCH to @janic/emit-close-on-blocked-ws for react-native-sandbox iOS fixes.
Configures git to use the token for HTTPS GitHub URLs. This allows override_deps.sh (yarn install of private webview fork) and any other HTTPS-based private repo access to authenticate without needing per-repo SSH deploy keys.
Use a single fine-grained PAT to authenticate all private repo access (git clone, yarn install of GitHub deps) via HTTPS git config insteadOf rules. Removes per-repo SSH key setup steps.
Replace SSH deploy keys and git insteadOf with gh CLI credential helper. Uses GH_TOKEN + gh auth setup-git for HTTPS auth, plus insteadOf to rewrite git@github.com: SSH URLs to HTTPS.
gh CLI requires GH_TOKEN on every step. Use git clone with HTTPS URLs instead, which works with the gh auth setup-git credential helper.
gh auth setup-git writes keys with leading spaces which breaks yarn's internal git clone. Strip leading whitespace from ~/.gitconfig after setup.
Root cause found: Yarn 4.2.2 + Git 2.52.0 incompatibility, fixed in rainbow-scripts by using yarn 4.12.0 in override_deps.sh.
janicduplessis force-pushed the @janic/sandbox-e2e-test branch from fc2334e to 8b4179e Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.