Prefix ids with table

[arbelt]

Summary

Initial implementation of prefixing element ids with the table id. This doesn't totally solve for potential duplicate IDs within a page, but should at least remove one of the most common sources (multiple tables with same column names).

This is a pretty big codebase. Happy to try to package this up more nicely but might need some pointers if there are interactions I'm missing.

Related GitHub Issues and PRs

• Ref: Column header IDs duplicated across tables #1247

Checklist

• I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• I have added testthat unit tests to tests/testthat for any new functionality.

[CLAassistant]

All committers have signed the CLA.

[olivroy]

Thanks for the PR. I didn't really review, but if you want the CI to pass, you will have to run tests locally and accept snapshot changes. i.e. with testthat::snapshot_accept() for us to see the direct implications of your changes.

Also, you have to change the expected digest value in test-as_raw_html.R` for tests to pass. This is normal when we change the html code of a table.

[arbelt]

thanks! I've updated some of the testing code & accepted snapshots, so they should pass, but I didn't have a chance to review all the snapshot changes

[arbelt]

@olivroy I've scanned through the snapshot results and addressed any issues I saw, so I think it's about set — at least no todos pending on my list for now.

[arbelt]

oops, should've run check. removed the test dependency on stringr, and also fixed the regex in the helper in the last commit