Skip to content

Give a name to the migrations example (#382)#383

Open
kriswuollett wants to merge 1 commit intorust-db:mainfrom
kriswuollett:refactor-named-examples
Open

Give a name to the migrations example (#382)#383
kriswuollett wants to merge 1 commit intorust-db:mainfrom
kriswuollett:refactor-named-examples

Conversation

@kriswuollett
Copy link
Copy Markdown
Contributor

No description provided.

@jxs jxs closed this Jul 25, 2025
@jxs
Copy link
Copy Markdown
Member

jxs commented Jul 25, 2025

pull request is stale, going to close

@kriswuollett
Copy link
Copy Markdown
Contributor Author

kriswuollett commented Jul 26, 2025

Why is the pull request stale? There is a linked issue for it that could be evaluated: closes #382.

@jxs
Copy link
Copy Markdown
Member

jxs commented Jul 26, 2025

cause it introduces no changes, sorry. Do you want to update it?
ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

@jxs jxs reopened this Jul 26, 2025
@kriswuollett
Copy link
Copy Markdown
Contributor Author

cause it introduces no changes, sorry. Do you want to update it? ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

You wish it to be added for documentation reasons? The package.autobins should be defaulting to true, so listing a named binary file in the manifest should be unnecessary unless customization is needed:

% cargo run --bin refinery-examples-migrate ... warning: `refinery-core` (lib) generated 5 warnings (run `cargo fix --lib -p refinery-core` to apply 4 suggestions) Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s Running `target/debug/refinery-examples-migrate`
@kriswuollett kriswuollett force-pushed the refactor-named-examples branch from 60ec2ce to 454e339 Compare July 27, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants