Skip to content

Migrate test files from tests/ui/issues to relevant directories in tests/ui/#154272

Open
ujjwalvishwakarma2006 wants to merge 3 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:migrate-ui-tests
Open

Migrate test files from tests/ui/issues to relevant directories in tests/ui/#154272
ujjwalvishwakarma2006 wants to merge 3 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:migrate-ui-tests

Conversation

@ujjwalvishwakarma2006
Copy link
Contributor

@ujjwalvishwakarma2006 ujjwalvishwakarma2006 commented Mar 23, 2026

In this pull request, I am migrating the following files and adding a comment at the top, including a link to the issue they were regression tests for:

  • tests/ui/issues/issue-4735.rs -> tests/ui/drop/drop-noncopyable-raw-pointer.rs
  • tests/ui/issues/issue-17734.rs -> tests/ui/drop/box-str-ice.rs

r? Kivooeo

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2026
@ujjwalvishwakarma2006 ujjwalvishwakarma2006 changed the title Migrate UI tests Migrate test files from tests/ui/issues to relevant directories in tests/ui/ Mar 23, 2026
@@ -1,3 +1,4 @@
//! regression test for <https://github.com/rust-lang/rust/issues/17734>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! regression test for <https://github.com/rust-lang/rust/issues/17734>
//! regression test for <https://github.com/rust-lang/rust/issues/4735>
@ujjwalvishwakarma2006 ujjwalvishwakarma2006 marked this pull request as ready for review March 24, 2026 07:53
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it to box-str-drop-glue and move it to ui/codegen-units.

I originally said to move it here, but I've taken a closer look and decided that this is a better place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no ui/codegen-units directory, I am migrating the test file to ui/codegen only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants