Skip to content

feat: add Delete method to remove scopes#140

Open
ohroy wants to merge 1 commit intosamber:masterfrom
ohroy:master
Open

feat: add Delete method to remove scopes#140
ohroy wants to merge 1 commit intosamber:masterfrom
ohroy:master

Conversation

@ohroy
Copy link

@ohroy ohroy commented Sep 28, 2025

fix #139

  • Resolved an issue where Shutdown didn't essentially remove the container. Essentially, this is a memory leak. (For example, I create a request scooe every time I make a request, and when I make a lot of requests, the containers will become more and more.)
  • To maintain API compatibility, here are two new APIs
Delete() *ShutdownReport Delete(ctx context.Context) *ShutdownReport

Essentially it's still calling Shutdown internally, and then appending the code from the parent scope. If itself is root scope, then do nothing.

  • Also add a test to verify logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant