This repository was archived by the owner on Nov 24, 2018. It is now read-only.
https://github.com/graphcool/chromeless/issues/332#335
Open
apokryfos wants to merge 1 commit intoschickling:masterfrom
apokryfos:master
Open
https://github.com/graphcool/chromeless/issues/332#335apokryfos wants to merge 1 commit intoschickling:masterfrom apokryfos:master
apokryfos wants to merge 1 commit intoschickling:masterfrom
apokryfos:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added copying the package.json to the dist directory part of the build and ava scripts and modified the version function since ../package.json will always be a valid path now.
PS: I'm not very confident about this change. I know it has resolved my specific issue but I'm not sure if there are other side-effects I haven't considered.