Skip to content

Pagination types feat/pagination-meta#1002

Open
gzukowski wants to merge 8 commits intodevelfrom
feat/pagination-meta
Open

Pagination types feat/pagination-meta#1002
gzukowski wants to merge 8 commits intodevelfrom
feat/pagination-meta

Conversation

@gzukowski
Copy link
Contributor

What?
Changed the types for responses.

Why?
Current reponses were not fitting for the additional content.

Usage:

-curl "0.0.0.0:11000/api/v1/cpm/{managerId}/api/v1/all_sequences?offset=1&limit=1"

Clickup Task:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes
@MichalCz
Copy link
Member

MichalCz commented Dec 4, 2023

This is a breaking change for sequences running with old manager API client. Please review with extra care.

@gzukowski gzukowski force-pushed the feat/pagination-meta branch from 1ba21e5 to b70d836 Compare December 8, 2023 14:53
@alicja-gruzdz
Copy link
Contributor

alicja-gruzdz commented Dec 11, 2023

It will be released together with
#900
#1002
due to breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants