Skip to content

fix: replace bit shift with proper SNARK field reduction in hash function #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace bit shift with proper SNARK field reduction in hash function #1047

wants to merge 1 commit into from

Conversation

@viktorking7
Copy link

@viktorking7 viktorking7 commented Sep 26, 2025

Description

Security Fix: Replaced unsafe bit shift operation with proper SNARK scalar field reduction in packages/proof/src/hash.ts.

Problem

The hash function was using >> 8n bit shift which discards 8 least significant bits of the keccak256 hash, significantly reducing cryptographic entropy and increasing collision risk.

Solution

  • Replaced bit shift with modular arithmetic using SNARK scalar field modulus
  • Preserves full hash entropy (256 bits → 248 bits was unsafe)
  • Maintains SNARK compatibility with proper field reduction
  • Eliminates collision risk from entropy loss
@viktorking7 viktorking7 requested a review from a team as a code owner September 26, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@viktorking7