feat(ui): replace DRS badge label with compact OVTK indicator#304
Open
MaximeBignolet wants to merge 1 commit intoslowlydev:mainfrom
Open
feat(ui): replace DRS badge label with compact OVTK indicator#304MaximeBignolet wants to merge 1 commit intoslowlydev:mainfrom
MaximeBignolet wants to merge 1 commit intoslowlydev:mainfrom
Conversation
| Channel 45 is actually removed this year, so this is no longer used |
Owner
| Yeah, I think we keep it as is atm. There’s no harm in it. And when the season starts, we can check again if they added any overtake or X / Z whatever mode, and then we can properly integrate that. Also, this CarData which we pull the DRS/gear/speed/throttle also isn't available to use anymore without a subscription, so technically it can just be removed completely. But let’s wait a few more days of testing and practice in Melbourne. |
Author
| Hey, Since the Melbourne race weekend is now over, do you want to revisit this PR? Happy to update it if needed (especially regarding the CarData removal if it’s no longer usable without subscription). Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the driver status badge to reflect current Formula 1 terminology by replacing the old
DRSlabel with a compactOVTKlabel.What changed
DriverDRSbadge text fromDRStoOVTKPITlabel unchangedtitleandaria-labelwith full text (OVERTAKE) for clarity and accessibilityWhy
DRSlabel is outdated in this contextOVERTAKEis too long for the available UI spaceOVTKpreserves readability without breaking the layoutImpact
Files touched
dashboard/src/components/driver/DriverDRS.tsx