Skip to content

UX improvements for renaming tabs#127

Open
JorrenH wants to merge 1 commit intosolidjs:masterfrom
JorrenH:feature/improvements-renaming-source-tabs
Open

UX improvements for renaming tabs#127
JorrenH wants to merge 1 commit intosolidjs:masterfrom
JorrenH:feature/improvements-renaming-source-tabs

Conversation

@JorrenH
Copy link
Copy Markdown

@JorrenH JorrenH commented Jan 15, 2023

I noticed some issues when renaming tabs in the playground. This PR implements/resolves the following:

  • Add 'Esc' as a button which stops editing tabname
  • Revert tabname when submitted as empty string
  • Store tabRefs by index, as names can change
  • Fix: focus sometimes not applied after doubleclick
  • Fix: cursor not active on doubleclick/focus (Firefox)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant