Dev/emma/as to satisfies gw by TheArcaneBrony · Pull Request #1585 · spacebarchat/server

TheArcaneBrony · 2026-03-10T19:48:19Z

pushing the messages one soon

oh64 · 2026-03-10T20:12:45Z

I realize that the openapi.json is not correct at all

TheArcaneBrony · 2026-03-10T21:44:11Z

never has been

oh64 · 2026-03-11T02:26:57Z

#1589

MathMan05 · 2026-03-20T15:35:11Z

src/api/routes/channels/#channel_id/messages/#message_id/ack.ts

 channel_id,
 message_id,
- version: 3763,
+ version: 3763, // what is this number?


it's the user read state version apparently
https://docs.discord.food/gateway/gateway-events#message-ack

MathMan05 · 2026-03-20T15:35:30Z

src/api/routes/channels/#channel_id/messages/#message_id/index.ts

+ ...new_message.toJSON(),
+ nonce: undefined,
+ },
+ } satisfies MessageUpdateEvent);


Why is this no longer promise.all?

this just avoids a case where saving the message fails for some reason, otherwise it'd still get sent to clients but then dissapear upon reload

MathMan05 · 2026-03-20T15:36:04Z

src/api/routes/channels/#channel_id/messages/#message_id/index.ts

 delete message.member;

+ await message.save();
+ const publicMsg = message.toJSON();


Is there a reason this isn't being done inline?

hm, i guess i could have?

It's fine either way for me, but you've in the past have said that single use stuff like this might better be inlined

MathMan05 · 2026-03-20T15:36:52Z

src/api/routes/channels/#channel_id/messages/pins/index.ts

 mention_everyone: false,
 });

+ await message.save();


can this not be added to the Promise.all?

prevents db invalid messages from being emitted

MathMan05 · 2026-03-20T15:37:15Z

src/api/routes/channels/#channel_id/messages/pins/index.ts


 message.pinned_at = null;

+ await message.save();


same here, why not in the Promise.all?

MathMan05 · 2026-03-20T15:38:07Z

src/api/routes/channels/#channel_id/greet.ts


 channel.last_message_id = message.id;

+ await message.save();


is there a reason for not being in the Promise.all?

MathMan05 · 2026-03-20T15:38:36Z

src/api/routes/channels/#channel_id/pins.ts

 mention_everyone: false,
 });

+ await message.save();


why not in the Promise.all?

MathMan05 · 2026-03-20T15:38:49Z

src/api/routes/channels/#channel_id/pins.ts


 message.pinned_at = null;

+ await message.save();


Why not in the Promise.all?

MathMan05 · 2026-03-20T15:39:26Z

src/api/routes/channels/#channel_id/thread-members.ts

 guild_id: thread.guild_id!,
 id: thread.id,
- member_count: thread.member_count,
+ member_count: thread.member_count ?? 0, //TODO: is this the right fix?


That is fine

MathMan05 · 2026-03-20T15:40:55Z

src/api/routes/channels/#channel_id/threads.ts

+ parse: body.message.allowed_mentions.parse as ("users" | "roles" | "everyone")[],
+ }
+ : undefined,
+ } as Parameters<typeof handleMessage>[0];


could satisfies be used here?

hm, im not sure if it can be, i think the entire point was to have type suggestions there but satisfies might conflict with futher handling (might make more sense to add right below, though, since it is using the first param of handleMessage as type)

Oh wait, this is an array of strings and you're narrowing it, right?

MathMan05 · 2026-03-20T15:42:44Z

src/api/routes/interactions/#interaction_id/#interaction_token/callback.ts

 data: {
 id: interactionId,
- nonce: interaction?.nonce,
+ nonce: interaction.nonce ?? "", // TODO: did i do this right?


it likely does not matter either way

alright, will remove the comment then

MathMan05 · 2026-03-20T15:43:50Z

src/api/routes/webhooks/#webhook_id/#token/index.ts

 data: {
 channel_id,
- guild_id: webhook.guild_id,
+ guild_id: webhook.guild_id!, // TODO: is this even the right fix?


as in, is this even correct? cause im asserting that guild_id isnt null (why can that even be null?)

MathMan05 · 2026-03-20T15:44:33Z

src/api/util/handlers/Webhook.ts

+ parse: body.allowed_mentions.parse as ("users" | "roles" | "everyone")[],
+ }
+ : undefined,
+ } as Parameters<typeof handleMessage>[0];


could satifies be used instead?

MathMan05 · 2026-03-20T15:45:06Z

src/gateway/events/Close.ts


 import { WebSocket } from "@spacebar/gateway";
 import { emitEvent, PresenceUpdateEvent, PrivateSessionProjection, Session, SessionsReplace, User, VoiceState, VoiceStateUpdateEvent } from "@spacebar/util";
+import member_id from "../../api/routes/guilds/#guild_id/members/#member_id";


what's up with this weird import?

good question, guessing it was automatically inserted

MathMan05 · 2026-03-20T15:46:11Z

src/schemas/api/channels/Channel.ts

 }
+
+// TODO: split up by channel type?
+export interface PublicChannel {


should this not be in schemas?

it... is? lol

MathMan05 · 2026-03-20T15:46:19Z

src/schemas/api/messages/Message.ts

 };
 }
+
+export interface PublicMessage {


should this not be in schemas?

it... is, lol - check the path again

MathMan05 · 2026-03-20T15:47:35Z

src/schemas/uncategorised/MessageActivity.ts

+
+export enum MessageActivityType {
+ JOIN = 1,
+ // @deprecated


While it is deprecated on the API should it be marked as a depricated part of the enum, that'll mean we'll get warns when we try to implement it

i was mirroring the deprecation from discord.food here

MathMan05 · 2026-03-20T15:48:46Z

src/util/entities/Message.ts

 mentions: this.mentions?.map((user) => {
 if (user && !user.toPublicUser) console.trace("toPublic user missing!!!");
- return user?.toPublicUser?.() ?? user ?? undefined;
+ return (user?.toPublicUser?.() ?? user ?? undefined) as unknown as PartialUser;


Might filter it out afterwards instead of doing this

as PartialUser|undefined).filter(=>!==undefined)

MathMan05

for those of which I clicked the wrong button

TheArcaneBrony requested a review from MathMan05 March 10, 2026 19:48

TheArcaneBrony linked an issue Mar 10, 2026 that may be closed by this pull request

Move from using as to satisfies for events #1577

Closed

MathMan05 reviewed Mar 20, 2026

View reviewed changes

TheArcaneBrony added 6 commits March 20, 2026 18:12

Migrate GuildMemberUpdate to satisfies, part of #1577

e0baf02

Migrate GuildUpdate to satisfies, part of #1577

95fa10b

Migrate ChannelDeleteEvent to satisfies, part of #1577

4cf9cd0

Migrate SettingsProto* to satisfies, part of #1577

366691b

Migrate InteractionCreateEvent to satisfies, part of #1577

0027218

Migrate Interaction*Event to satisfies, part of #1577

7a791cd

TheArcaneBrony and others added 28 commits March 20, 2026 18:16

Migrate GuildDeleteEvent to satisfies, part of #1577

58df260

Migrate GuildMember*Event to satisfies, part of #1577

7f3b47d

Migrate GuildEmoji*Event to satisfies, part of #1577

3462b40

Migrate GuildRole*Event to satisfies, part of #1577

8a5d884

Migrate GuildStickersUpdateEvent to satisfies, part of #1577

ee53b72

Migrate Member#addToGuild GuildCreateEvent to satisfies, part of #1577

2a1d8ff

Migrate Relationship*Event to satisfies, part of #1577

de64db6

Migrate WebhooksUpdateEvent to satisfies, part of #1577

52efc75

Migrate Channel*Event to satisfies, part of #1577

b59f41c

Migrate Invite*Event to satisfies, part of #1577

1fb0af8

Migrate VoiceS*Event to satisfies, part of #1577

9597ebe

Migrate UserUpdateEvent to satisfies, part of #1577

851f0e7

Migrate PresenceUpdateEvent to satisfies, part of #1577

bd42196

Migrate Stream*Event to satisfies, part of #1577

66bed97

Migrate MessageAckEvent to satisfies, part of #1577

aa94101

Migrate UserDeleteEvent to satisfies, part of #1577

847dc84

Migrate ReadyEventData to satisfies, part of #1577

9e42745

Migrate MessageDelete*Event to satisfies, part of #1577

3d8a91b

Migrate Thread*Event to satisfies, part of #1577

339a0fc

Migrate TypingStartEvent to satisfies, part of #1577

4c169ba

Migrate MessageReaction*Event to satisfies, part of #1577

131a0ec

MessageActivity: add type enum

1c3c609

MessageCreate/UpdateEvent: use PublicMessage

5effba7

Message*Event: as->satisfies (WIP)

f333e8d

Message toJSON -> null vs undefined

46176e9

More schema stuff

27d2ba5

Add WIP PublicMessage schema

a4e87dd

make spacebar compile again

7a92946

TheArcaneBrony force-pushed the dev/emma/as-to-satisfies-gw branch from d483ca4 to 7a92946 Compare March 21, 2026 07:28

TheArcaneBrony merged commit 7a92946 into master Mar 21, 2026
0 of 3 checks passed

Uh oh!

Conversation

TheArcaneBrony commented Mar 10, 2026

oh64 commented Mar 10, 2026

TheArcaneBrony commented Mar 10, 2026

oh64 commented Mar 11, 2026

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MathMan05 left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

3 participants