Existing code rewrite, add typescript, add classes and interfaces, add unit test #1 #2 #3 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ho finito di modificare un po il driver:
ho spezzettato metodi lunghi in piu parti, specialmente parseData
ho messo tutte le variabili per esteso
ho messo tutti i tipi per typescript
ho tolto qualche variabile che non veniva usata
ho creato una classe per le configurazioni
aggiunto che si possa creare la connessione usando un url
creato SQLiteCloudError per passare i nostri errori
tirato via la connessione con socket non criptato
todo magari poi tiro via un po dei log di diagnostica…