Revert "refactor(s3): replace hardcoded Tencent COS detection with extensible endpoint strategy pattern"

[sysfox]

Reverts #11

Summary by CodeRabbit

• Refactor
  • Simplified S3 upload endpoint resolution by consolidating strategy-based logic into inline implementation. Endpoint handling for Tencent COS and standard S3 services is now processed directly within the upload method for improved maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef095de and 211f9fd.

📒 Files selected for processing (2)

• apps/core/src/utils/s3.util.spec.ts
• apps/core/src/utils/s3.util.ts

---

📝 Walkthrough

Walkthrough

Refactoring removes the strategy pattern for S3 endpoint resolution. The TencentCosEndpointStrategy, DefaultS3EndpointStrategy classes and strategy-based infrastructure are deleted. Endpoint resolution logic is inlined directly into S3Uploader.uploadToS3, handling Tencent COS and standard endpoints through conditional logic. Related tests for strategy behavior are also removed.

Changes

Cohort / File(s)	Summary
S3 Strategy Pattern Removal apps/core/src/utils/s3.util.ts, apps/core/src/utils/s3.util.spec.ts	Removed S3EndpointStrategy interface, TencentCosEndpointStrategy, DefaultS3EndpointStrategy, and registerStrategy mechanism. Inlined endpoint/host resolution directly in uploadToS3 with conditional Tencent COS detection. Deleted corresponding strategy tests; test imports refactored to import directly from s3.util.
Package Configuration package.json	Updated package manifest; lines adjusted across dependencies or configuration entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 Strategies once danced in layers deep,
Now bundled tight, one logic to keep,
Tencent and standard, side by side,
Inlined with simplicity and pride! ✨

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-11-copilot/add-conversion-strategy-class

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}