Log Activity Panic at Workflow Caller Level#2229
Open
brucearctor wants to merge 1 commit intotemporalio:masterfrom
Open
Log Activity Panic at Workflow Caller Level#2229brucearctor wants to merge 1 commit intotemporalio:masterfrom
brucearctor wants to merge 1 commit intotemporalio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log Activity Panic at Workflow Caller Level
Fixes #2204.
ApplicationErrorwith aPanicErrorstructure was created securely, but thesdk-gopackage failed to intercept and log the panic traceback at theWorkflowTaskHandlerlevel.internal_event_handlers.goinhandleActivityTaskFailedandhandleLocalActivityMarker. The code now explicitly checks if the decoded error wraps aPanicError. If it does, a nativelogger.Errorlogs the associated fields (tagPanicErrorandtagPanicStack).TestActivityTask_ActivityPanicstointernal/internal_task_handlers_test.goand verified against the fullsdk-gotest suite to check for correctness and absence of regressions.