Skip to content

test MLKit PR build #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

test MLKit PR build #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1ce066
refactor(database): rename transactions snippet variable
thatfiredev Apr 13, 2020
01e0e83
Merge branch 'master' of https://github.com/firebase/quickstart-android
thatfiredev Apr 23, 2020
5e4c11b
remove dot for testing purposes
thatfiredev Apr 23, 2020
4ba8f78
test mlkit-langid change
thatfiredev Apr 24, 2020
dcfd76e
update build_pull_request.sh
thatfiredev Apr 24, 2020
37b0e05
test mlkit-smartreply
thatfiredev Apr 24, 2020
49626f7
test a module that does not contain 'mlkit'
thatfiredev Apr 24, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion auth/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ check.dependsOn 'assembleDebugAndroidTest'
android {
compileSdkVersion 29
flavorDimensions "minSdkVersion"

defaultConfig {
applicationId "com.google.firebase.quickstart.auth"
minSdkVersion 16
Expand Down
2 changes: 1 addition & 1 deletion build_pull_request.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ git fetch origin
# Get all the modules that were changed
while read line; do
module_name=${line%%/*}
if [[ ${MODULES} != *"${module_name}"* ]]; then
if [[ ${MODULES} != *"${module_name}" ]]; then
MODULES="${MODULES} ${module_name}"
fi
done < <(git diff --name-only origin/$GITHUB_BASE_REF)
Expand Down
1 change: 1 addition & 0 deletions mlkit-langid/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ buildscript {
}
}


allprojects {
repositories {
mavenLocal()
Expand Down
1 change: 0 additions & 1 deletion mlkit-smartreply/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ android {
enabled = true
}
}

dependencies {
implementation project(':internal:chooserx')
implementation project(":internal:lintchecks")
Expand Down
2 changes: 1 addition & 1 deletion mlkit/app/src/main/java/EntryChoiceActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class EntryChoiceActivity : BaseEntryChoiceActivity() {
com.google.firebase.samples.apps.mlkit.java.ChooserActivity::class.java)),
Choice(
"Kotlin",
"Run the Firebase ML Kit quickstart written in Kotlin.",
"Run the Firebase ML Kit quickstart written in Kotlin",
Intent(
this,
com.google.firebase.samples.apps.mlkit.kotlin.ChooserActivity::class.java))
Expand Down