feat(clean): align Composer cache cleanup with documented cache-dir resolution#638
Open
feat(clean): align Composer cache cleanup with documented cache-dir resolution#638
Conversation
Implement a dedicated clean_composer_cache function that checks multiple possible cache locations in a defined priority order: 1. $HOME/.composer/cache (legacy) 2. $HOME/Library/Caches/composer (macOS) 3. XDG_CACHE_HOME/composer (XDG standard) 4. COMPOSER_HOME/cache (Composer-specific) 5. LOCALAPPDATA/Composer (Windows) This ensures proper cache cleanup across different platforms and Composer configurations while maintaining backward compatibility.
MASNathan changed the title Remove complex multi-path detection for Composer cache and replace with explicit cleaning of two known paths. Update whitelist entry to distinguish legacy and current cache locations. Adjust tests to reflect new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-dirresolution order from the official docs:%LOCALAPPDATA%/Composer~/Library/Caches/composer$XDG_CACHE_HOME/composer$COMPOSER_HOME/cache(and existing~/.composer/cachecompatibility)Why
Composer uses a single effective cache directory based on environment and platform. Cleaning multiple potential paths is unnecessary and can introduce noise/risk. This change makes Mole's behavior deterministic and consistent with Composer docs:
https://getcomposer.org/doc/06-config.md#cache-dir
Tests
bats tests/clean_dev_caches.batsbash -n lib/clean/dev.shshellcheck lib/clean/dev.sh tests/clean_dev_caches.bats