Skip to content

chore: added deserialization classes#882

Draft
sbansla wants to merge 2 commits intomainfrom
custom-deserialisation
Draft

chore: added deserialization classes#882
sbansla wants to merge 2 commits intomainfrom
custom-deserialisation

Conversation

@sbansla
Copy link
Contributor

@sbansla sbansla commented Aug 4, 2025

Fixes

Going forward we are going to use custom deserialization classes instead of having private constructor based deserialization.
Now:

this.dateSent = DateConverter.rfc2822DateTimeFromString(dateSent);

New Changes:
Remove Constructor and use lombok annotations
@JsonDeserialize(using = CustomDeserializer)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@tiwarishubham635 tiwarishubham635 force-pushed the main branch 2 times, most recently from 6533f63 to 78a8ccd Compare September 9, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants