Open
Conversation
8 tasks
a1rwulf approved these changes Apr 13, 2024
Contributor
| You also have to enable these constants in the header file |
Member
Oh indeed my bad, didn’t think about that. Thx for the catch!! libandroidjni/src/PlaybackState.h Line 31 in e9ed532 |
Contributor
| In order to be used from other classes they need to be in the header. |
Member Author
Thanks git add for the win ;-) |
Member Author
| Let's keep it open for a bit - I want to fix the other bug for the MediaSession first and time is very limited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should properly identify the actions of the media session as well, cause SetActions needs them.