OnClickListener on Views inside a custom ScrollView

Question

I'm havin a horizontal ScrollView inside a ViewPager. To prevent the ViewPager to be scrolled when the end of the ScrollView is reached I use this class as per hint on SO:

public class CustomScrollView extends HorizontalScrollView { public CustomScrollView(Context p_context, AttributeSet p_attrs) { super(p_context, p_attrs); } @Override public boolean onInterceptTouchEvent(MotionEvent p_event) { return true; } @Override public boolean onTouchEvent(MotionEvent p_event) { if (p_event.getAction() == MotionEvent.ACTION_MOVE && getParent() != null) { getParent().requestDisallowInterceptTouchEvent(true); } return super.onTouchEvent(p_event); } }

The onInterCeptTouchEvent seems to consume any click to that View and everything inside it. When I put Views into that ScrollView, their OnClickListeners won't be called.

When I let onInterceptTouchEvent return false, the OnClickListeners are called, but the ScrollView can't be scrolled.

How can I put clickable Views inside that ScrollView?

EDIT: After implementing Rotem's answer, the onClickListener works, but it doesn't only fire on click events but also on others, like fling. How can this be prevented?

Rotem · Accepted Answer · 2013-04-15 14:48:20Z

11

try to call onTouchEvent inside the implementation of onInterceptTouchEvent and then return false.

answered Apr 15, 2013 at 14:48

Rotem

1,4922 gold badges11 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fweigl · Accepted Answer · 2013-04-23 11:32:32Z

5

Well, minutes after starting a bounty I found out how it works:

in onInterceptTouchEvent I

return super.onInterceptTouchEvent(p_event);

answered Apr 23, 2013 at 11:32

fweigl

22.2k24 gold badges123 silver badges217 bronze badges

2 Comments

Rotem Over a year ago

if you only call super with same arguments, there's no need to override the method

Rob Pridham Over a year ago

Ensure you read the Javadoc for your methods, which describes your problem. As Rotem says, you don't need to implement this one.

Akram · Accepted Answer · 2014-01-15 07:55:01Z

Here is complete solution using answers to this question.

public class CustomHorizontalScrollView extends HorizontalScrollView { public CustomHorizontalScrollView(Context context) { super(context); } public CustomHorizontalScrollView(Context context, AttributeSet attrs) { super(context, attrs); } @Override public boolean onInterceptTouchEvent(MotionEvent ev) { boolean result = super.onInterceptTouchEvent(ev); if(onTouchEvent(ev)) { return result; } else { return false; } } @Override public boolean onTouchEvent(MotionEvent ev) { if (ev.getAction() == MotionEvent.ACTION_MOVE && getParent() != null) { getParent().requestDisallowInterceptTouchEvent(true); } return super.onTouchEvent(ev); } }

Collectives™ on Stack Overflow

OnClickListener on Views inside a custom ScrollView

3 Answers 3

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Related