In your if and else blocks, you are actually creating new variables with the name of numberType, and that those new variables hide the original numberType you had previously declared. Any changes you make on those variables will NOT reflect to the original numberType, as they do not refer to it.
To solve that problem, remove the string parts (the types, as having these denotes that you are defining new variables) as you don't want to define those new variables, and want use the previously defined numberType.
if (userInput % 2 == 0) { numberType = "Even"; // Look ma, no string! } else { numberType = "Odd"; // Also here ma! }
With the modified and fixed code, you are now referring to the numberType where you intend to put the values "Even" or "Odd".
... int userInput; string numberType; // This is now where the values be put in cout << "Enter a number and I will Check to see if it is odd or even" << endl; ...
This should now give you the correct and desired output.
stringdeclaration type when assigning it. You'll get what you're looking for.