foreach and for javascript

Question

For each 'a'-tag (.arrow-class), I want to add an anchor tag of a .jump-class, but I'm stuck using the foreach and for functions. This is what I have, but the 'a'-tag gets the last value in the array:

var arr = []; $(".jump").each(function () { var id = $(this).attr('id'); arr.push(id); }); var arrayLength = arr.length; $(".arrow").each(function () { for (var i = 0; i < arrayLength; i++) { $(this).attr("href", arr[i]); } });

EDIT: ANSWER:

var arr = []; $(".jump").each(function () { var id = $(this).attr('id'); arr.push(id); }); var arrayLength = arr.length; for (var i = 0; i < arrayLength; i++) { $(".arrow").each(function (i) { $(this).attr("href", '#' + arr[i]); }); }

don't use an inner loop on the 2nd one, you're not iterating the arrows ever. use the params supplied to forEach to provide "i" — dandavis
– dandavis, Commented Dec 7, 2014 at 0:10
@EthanBrown: I think they mean they're "stuck" as in having trouble using them, not that they must use them. — Cᴏʀʏ
– Cᴏʀʏ, Commented Dec 7, 2014 at 0:11
$(this).attr("href", arr[i]); --- this statement is run multiple times for every .arrow — zerkms
– zerkms, Commented Dec 7, 2014 at 0:11

andrew · Accepted Answer · 2014-12-07 00:12:41Z

this is going to loop more times than you need

$(".arrow").each(function () { for (var i = 0; i < arrayLength; i++) { $(this).attr("href", arr[i]); } });

Instead try

$(".arrow").each(function (i,arrow) { $(arrow).attr("href", arr[i]); });

Collectives™ on Stack Overflow

foreach and for javascript

1 Answer 1

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Related