ui-router controller or angular controller

Question

I am using ui-router for routing my app. On ui-router I can define controller like

myApp.config(function($stateProvider, $urlRouterProvider) { // // For any unmatched url, redirect to /state1 $urlRouterProvider.otherwise("/state1"); // // Now set up the states $stateProvider .state('state1', { url: "/state1", templateUrl: "partials/state1.html" }) .state('state1.list', { url: "/list", templateUrl: "partials/state1.list.html", controller: function($scope) { $scope.items = ["A", "List", "Of", "Items"]; } })

here you can see the controller definition on ui-router state object.

My question is, what is more common, define an angular controller or ui-router controller?

angular.module('controllerExample', []) .controller('SettingsController2', ['$scope', SettingsController2]);

Ben Diamant · Accepted Answer · 2015-02-15 18:22:01Z

'What's more common' is a very broad question, but.

There are few things to consider:

What type of state and how nested is it (If its a nested state that only displays a bulk of data that's might be fine)
How large the controller is? (2-3 lines of logic can be handled inline)
How do you structure your app?

In the end, a better practice is to put all in an organized 1 spot and not splitting your controller definition, so if to choose from both approaches, don't define your controller inline.

In general, I recommend to go over this style guide - (very popular) - github.com/johnpapa/angularjs-styleguide

Radim Köhler · Accepted Answer · 2015-02-15 17:41:58Z

I could not say what is more common, just why to use the second approach.

Firstly, if we declare the controller as SettingsController2 (object/function), we can use it multiple times.

Secondly, this approach creates a real type, which could be later easily trakced (found) once you observe the pefromance tools (memory profiler)

Finally, if we will use some JS++ like Typescript or AtScript, we can easily use inheritance and even other features...

So do not use inline def, if possible

Collectives™ on Stack Overflow

ui-router controller or angular controller

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related