Try Catch Block not preventing exception

Question

I am building a program that will move a bunch of files.

 if (line.Contains("INSERT INTO BACKLOGITEM_ATTACHMENT VALUES")) { string AttachementID = line.Split(',', ')')[1]; string FileName = AttachementsDictionary[AttachementID]; string BacklogScrumID = BacklogLookupDictionary[AttachementID]; BacklogItem Story = BacklogItemDictionary[BacklogScrumID]; Product Product = ProductDictionary[Story.ProductScrumId]; string FileToCopy = "\\\\dxScrum01v\\ScrumWorksPro\\scrumworks\\data\\attachments\\product" + Story.ProductScrumId + "\\attachement" + AttachementID; string FileToSave = "C:\\ScrumWorksAttachementExport\\" + Product.ProductName + "\\" + Product.StoryPrefix + "-" + Story.StoryTitle + "\\" + FileName; //Console.WriteLine(FileToCopy + " >>> " + FileToSave); try { File.Copy(@FileToCopy, @FileToSave); } catch (Exception) { Console.WriteLine("Failed: " + FileToSave); throw; } }

The issue is that I am getting an exception when running the program. There are times when the file does not exist.

How can I make it so that if it fails it just outputs the failure and keeps going?

throw inside a catch does not get caught by the outer catch, so it will still break inside the debugger. — Ron Beyer
– Ron Beyer, Commented Oct 26, 2015 at 19:03
While not a fail safe mechanism add a File.Exists before executing the copy — Steve
– Steve, Commented Oct 26, 2015 at 19:04
By the way, there is no reason to use the @ in front of the variables, and you should be using it when you specify the file path (to avoid double backslashes). — Ron Beyer
– Ron Beyer, Commented Oct 26, 2015 at 19:17

Mladen Oršolić · Accepted Answer · 2015-10-26 19:04:20Z

3

Remove throw; if you dont want your application to break, you can handle the exception too

answered Oct 26, 2015 at 19:04

Mladen Oršolić

1,4323 gold badges24 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Try Catch Block not preventing exception

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related