Error when attempting to write to file on new line

Question

As shown below, the code's purpose is to read from a file and store the new names inside a list. The user is prompted to enter as many names as they like until they input 'end'.

def name(): with open("Names.txt") as f: data = f.readlines() while True: name = raw_input('Input: ').upper() data.append(name) if name == "END": data.remove("END") data.sort() print data for i in data: f.write("%s\n" % i) f.close() name()

I am attempting to write the ordered list to a file like so:

for i in data: f.write("%s\n" % i)

However, it results in the following error:

f.write("%s\n" % i) ValueError: I/O operation on closed file

I would've expected the file to contain something a little like assuming :

Alex Ben Callum David ...

Ke Li · Accepted Answer · 2017-03-20 11:18:38Z

Because the file is closed before you trying to write the data into the file.

def name(): with open("Names.txt") as f: data = f.readlines() # here file is closed while True: name = raw_input('Input: ').upper() data.append(name) if name == "END": data.remove("END") data.sort() print data with open("Names.txt", 'w') as f: for i in data: f.write("%s\n" % i) name()

You need to open the file again when writing data.

Thanks ;-) Works great. You might just want to fix the indentation ;-)

Collectives™ on Stack Overflow

Error when attempting to write to file on new line

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related