How do I alternatively uppercase and lowercase characters in a string?

Question

I don't understand what's wrong with this function I coded for a kata in Codewars.

These are the instructions:

Write a function toWeirdCase (weirdcase in Ruby) that accepts a string, and returns the same string with all even indexed characters in each word upper cased, and all odd indexed characters in each word lower cased. The indexing just explained is zero based, so the zero-ith index is even, therefore that character should be upper cased.

The passed in string will only consist of alphabetical characters and spaces(' '). Spaces will only be present if there are multiple words. Words will be separated by a single space(' '). Examples:

weirdcase( "String" )#=> returns "StRiNg" weirdcase( "Weird string case" );#=> returns "WeIrD StRiNg CaSe"

Here's the function I coded:

def to_weird_case(string): return "".join(char.upper() if string.find(char) % 2 == 0 else char.lower() for char in string)

Here's the result I get:

Time: 695ms Passed: 5 Failed: 8 Exit Code: 1 Test Results: toWeirdCase should return the correct value for a single word Test Passed Test Passed Test Passed 'TeST' should equal 'TeSt' 'LookS' should equal 'LoOkS' Test Passed Test Passed 'PaSSEd' should equal 'PaSsEd' should return the correct value for multiple words 'ThIs Is A TesT' should equal 'ThIs Is A TeSt' 'LookS Like you pASSeD' should equal 'LoOkS LiKe YoU PaSsEd' 'ThIs Is ThE FINaL TEsT casE' should equal 'ThIs Is ThE FiNaL TeSt CaSe' 'JuSt kIddINg' should equal 'JuSt KiDdInG' 'Ok fInE YoU ArE DonE now' should equal 'Ok FiNe YoU ArE DoNe NoW'

It looks like it passes some of the tests, while it struggles with a couple of single words and every sentence. Does any of you know what I am doing wrong? Thanks.

in 'Ok fInE you have lower f but it has to be upper F. You have to convert every word separately but it seems you convert all words as single string. — furas
– furas, Commented Apr 20, 2019 at 13:15
string.find(char) is not good idea - for second T in work test it gives you position of first T. better use enumerate(word) — furas
– furas, Commented Apr 20, 2019 at 13:18

Devesh Kumar Singh · Accepted Answer · 2019-04-20 13:25:27Z

Just iterate through the characters, and for odd or even character, convert to lower or upper chars. We do this for each word in the list by splitting the string into a list of words, and then stitching the string back.

def to_weird_case(s): li = s.split() res = [] for s in li: result = '' for idx, c in enumerate(s): if idx%2 == 0: result += c.upper() else: result += c.lower() res.append(result) return ' '.join(res)

The outputs are

print(to_weird_case('String')) print(to_weird_case("Weird string case")) print(to_weird_case("TeST")) print(to_weird_case("LookS")) print(to_weird_case("PaSSEd")) print(to_weird_case("ThIs Is A TesT")) print(to_weird_case("LookS Like you pASSeD")) print(to_weird_case("ThIs Is ThE FINaL TEsT casE")) print(to_weird_case("JuSt kIddINg")) print(to_weird_case("Ok fInE YoU ArE DonE now")) #StRiNg #WeIrD StRiNg CaSe #TeSt #LoOkS #PaSsEd #ThIs Is A TeSt #LoOkS LiKe YoU PaSsEd #ThIs Is ThE FiNaL TeSt CaSe #JuSt KiDdInG #Ok FiNe YoU ArE DoNe NoW

jayprakashstar · Accepted Answer · 2019-04-20 13:17:59Z

str.find('char') returns the first index it finds the character so your case it will not work properly for repetitive characters

def to_weird_case(string): return "".join(char.upper() if i% 2 == 0 else char.lower() for i, char in enumerate(string))

Collectives™ on Stack Overflow

How do I alternatively uppercase and lowercase characters in a string?

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related