0

I am trying to use the rand() and srand() function to generate a random number in the index of an array, but it outputs the same thing every single time. What gives? I want my output to be able to display a different color every time I execute my code.

AREAS OF FOCUS:

  1. void randomPick()

    int random = rand() % 7; cout << "Random color = " << colors[random] << endl;

  2. srand((unsigned int)time(NULL))

 #include <iostream> #include <string> #include <cstdlib> #include <ctime> using namespace std; class randColor { private: string colors[7]; public: // set element to assign values to array void setElement(int index, string color) { colors[index] = color; } void printColor() { int i = 0; for(i = 0; i < 7; i++) { cout << colors[i] << endl; } } void randomPick() { int random = rand() % 7; cout << "Random color = " << colors[random] << endl; } }; int main() { srand((unsigned int)time(NULL)); randColor RandomOne; const string colors[7] = {"red", "orange", "yellow", "blue", "green", "indigo", "violet"}; for (int i = 0; i < 7; i++) { RandomOne.setElement(i, colors[i]); } RandomOne.printColor(); RandomOne.randomPick(); return 0; }
Improve this question
3
  • Your program looks good to me. I get varying radom picks on my laptop. Commented Sep 10, 2020 at 20:13
  • I get a different color over different runs. onlinegdb.com/H16ad-O4D time(NULL) only changes once per second so if you are running it back to back quickly you may get the same value. Commented Sep 10, 2020 at 20:15
  • You should be able to simplify your example if you replaced cout << "Random color = " << colors[random] << endl; with cout << "Random number = " << random << endl; then removed the no longer needed pieces. (Getting the same number in the simpler example implies getting the same color in the current version.) Commented Sep 10, 2020 at 22:04

2 Answers 2

Reset to default
4

am trying to use the rand() and srand() function to generate a random number in the index of an array, but it outputs the same thing every single time. What gives?

It doesn't output the same thing every time. Or rather - you're printing all the colors first - which is obviously not random - then you print the name of the randomly-chosen color. It's not the same thing every time...

That aside - you should avoid using rand() (or watch the talk by Stephen Lavavej on this matter). Do it the C++ way instead!

Improve this answer
Sign up to request clarification or add additional context in comments.

5 Comments

It can output the same thing if you run the program in a tight loop within a second. Assuming time_t is seconds, of course.
I'm seeing a call to srand. OP must be juggling their question around.
@user4581301: Fair enough, so +1 on your comment, but somehow I don't think that's the scenario OP was dealing with.
It's unlikely, but I've seen it in the wild. And wanted to slap the guy for using system to call a random number generating program.
@user4581301: Maybe your guy is an ardent bash user, so he goes with what he knows.
3

As people have stated, you call the printColor() function, which will always look the same. Only the last color should be randomized. And because you only call it once, it makes sense that you'll see repeats quite often since your data set is so small.

So I've made a few changes to your code. Namely, instead of the weaker srand() / rand() / modulo math route, I use <random>. Your class has a static PRNG attached to it, and now all the random number generation code is contained in your class. The last big change I made was to call randomPick() multiple times so you can get a better view of the fact that the color is indeed changing on successive calls.

Depending on your intended use, it might be better to simply std::shuffle() the array and then read all the elements.

I've also removed the line using namespace std; and made the appropriate changes. It's a bad practice.

#include <iostream> #include <random> // Better for C++ #include <string> class randColor { private: std::string colors[7]; static std::mt19937 m_prng; static std::uniform_int_distribution<int> m_dist; public: // set element to assign values to array void setElement(int index, std::string color) { colors[index] = color; } void printColor() { int i = 0; for (i = 0; i < 7; i++) { std::cout << colors[i] << '\n'; } } void randomPick() { int random = m_dist(m_prng); std::cout << "Random color = " << colors[random] << '\n'; } }; std::mt19937 randColor::m_prng(std::random_device{}()); std::uniform_int_distribution<int> randColor::m_dist(0, 6); int main() { srand((unsigned int)time(NULL)); randColor RandomOne; const std::string colors[7] = {"red", "orange", "yellow", "blue", "green", "indigo", "violet"}; for (int i = 0; i < 7; i++) { RandomOne.setElement(i, colors[i]); } // RandomOne.printColor(); for (int i = 0; i < 10; ++i) RandomOne.randomPick(); return 0; } }
Improve this answer

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.